Add streaming PDF page loading and improve PDF rendering#76
Open
ShayDuane wants to merge 1 commit intozai-org:mainfrom
Open
Add streaming PDF page loading and improve PDF rendering#76ShayDuane wants to merge 1 commit intozai-org:mainfrom
ShayDuane wants to merge 1 commit intozai-org:mainfrom
Conversation
- Add iterator-based page loading in PageLoader and use it in the async pipeline data-loading thread - Introduce pdf_to_images_pil_iter and make PDF rendering more robust with proper resource cleanup in image_utils On branch feature/pdf Changes to be committed: modified: glmocr/dataloader/page_loader.py modified: glmocr/pipeline/pipeline.py modified: glmocr/utils/image_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
modified: glmocr/dataloader/page_loader.py
modified: glmocr/pipeline/pipeline.py
modified: glmocr/utils/image_utils.py
Contribution Guide
We welcome your contributions to this repository. To ensure elegant code style and better code quality, we have prepared
the following contribution guidelines.
What We Accept
follows the coding standards below.
your code strictly follows the coding standards below.
Code Style Guide
Good code style is an art. We have prepared a
pre-commithook to enforce consistent codeformatting across the project. You can clean up your code following the steps below:
If your code complies with the standards, you should not see any errors.
Naming Conventions
a,b,c.